Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Open the detour modal from a notification #2835

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

hannahpurcell
Copy link
Collaborator

@hannahpurcell hannahpurcell commented Oct 1, 2024

Asana Ticket: https://app.asana.com/0/1148853526253420/1207752079129768/f

Essentially reopening #2825 but with conflicts resolved and merging to main now

Sorry for the lingering broken test! Again, unsure how to force a wait in a way that would resolve the issue

Co-authored-by: Josh Larson <jlarson@mbta.com>
@hannahpurcell hannahpurcell requested a review from a team as a code owner October 1, 2024 21:06
@hannahpurcell hannahpurcell marked this pull request as draft October 1, 2024 21:06
@hannahpurcell hannahpurcell marked this pull request as ready for review October 3, 2024 13:19
Copy link
Member

@firestack firestack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approving since comments need to be resolved to merge, and if those are resolved (and tests pass) I'm good with this.

@hannahpurcell hannahpurcell merged commit 227ac53 into main Oct 9, 2024
9 checks passed
@hannahpurcell hannahpurcell deleted the hp/open-detour-modal-from-notification branch October 9, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants